Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple use of otel/internal/internaltest #4424

Merged
merged 10 commits into from
Aug 9, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Aug 8, 2023

Part of #3846

  • Add the otel/internal/internaltest package as templates to otel/internal/shared
  • Generate local internaltest packages for all uses outside of the otel module:
    • sdk
    • exporters/jaeger
    • exporters/zipkin
  • Use the local internaltest for the packages with a generated copy

@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 8, 2023
@MrAlias MrAlias marked this pull request as draft August 8, 2023 15:33
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #4424 (d71e7f3) into main (e3ed198) will decrease coverage by 2.3%.
The diff coverage is 48.6%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4424     +/-   ##
=======================================
- Coverage   83.5%   81.2%   -2.3%     
=======================================
  Files        229     247     +18     
  Lines      18679   19996   +1317     
=======================================
+ Hits       15605   16246    +641     
- Misses      2755    3407    +652     
- Partials     319     343     +24     
Files Changed Coverage Δ
...xporters/jaeger/internal/internaltest/alignment.go 0.0% <0.0%> (ø)
exporters/jaeger/internal/internaltest/errors.go 0.0% <0.0%> (ø)
exporters/jaeger/internal/internaltest/harness.go 0.0% <0.0%> (ø)
...xporters/zipkin/internal/internaltest/alignment.go 0.0% <0.0%> (ø)
exporters/zipkin/internal/internaltest/errors.go 0.0% <0.0%> (ø)
exporters/zipkin/internal/internaltest/harness.go 0.0% <0.0%> (ø)
internal/internaltest/alignment.go 0.0% <ø> (ø)
internal/internaltest/env.go 73.8% <ø> (ø)
internal/internaltest/errors.go 0.0% <ø> (ø)
internal/internaltest/harness.go 0.0% <ø> (ø)
... and 14 more

... and 2 files with indirect coverage changes

@MrAlias MrAlias marked this pull request as ready for review August 8, 2023 15:40
@pellared pellared merged commit b7f634a into open-telemetry:main Aug 9, 2023
19 of 21 checks passed
@MrAlias MrAlias deleted the gotmpl-internaltest branch August 9, 2023 13:59
@MrAlias MrAlias added this to the v1.17.0/v0.40.0 milestone Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants