-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate the otlp/internal package and all sub-packages #4421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
requested review from
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
August 7, 2023 16:46
MrAlias
force-pushed
the
dep-otlp-internal
branch
from
August 7, 2023 16:48
5ecf254
to
7baa559
Compare
dashpole
approved these changes
Aug 7, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4421 +/- ##
=====================================
Coverage 83.5% 83.5%
=====================================
Files 229 229
Lines 18679 18679
=====================================
Hits 15605 15605
Misses 2755 2755
Partials 319 319
|
MrAlias
force-pushed
the
dep-otlp-internal
branch
from
August 7, 2023 20:57
a8c3260
to
721b3bf
Compare
hanyuancheung
approved these changes
Aug 8, 2023
pellared
approved these changes
Aug 8, 2023
pellared
reviewed
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3846
This is the last clean up needed to deprecate the
otlp/internal
package.WrapTracesError
with equivalentfmt.Errorf
otlp/internal
otlp/internal
.The plan is to remove
otlp/internal
after this has been released.