Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the otlp/internal package and all sub-packages #4421

Merged
merged 11 commits into from
Aug 8, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Aug 7, 2023

Part of #3846

This is the last clean up needed to deprecate the otlp/internal package.

  • replace use of WrapTracesError with equivalent fmt.Errorf
  • Deprecate otlp/internal
    • Ignore lint for all other packages about to be deprecated that import the now deprecated otlp/internal.

The plan is to remove otlp/internal after this has been released.

@MrAlias MrAlias added the pkg:exporter:otlp Related to the OTLP exporter package label Aug 7, 2023
@MrAlias MrAlias added this to the v1.17.0/v0.40.0 milestone Aug 7, 2023
@MrAlias MrAlias marked this pull request as draft August 7, 2023 19:15
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #4421 (4c7e314) into main (6631519) will not change coverage.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4421   +/-   ##
=====================================
  Coverage   83.5%   83.5%           
=====================================
  Files        229     229           
  Lines      18679   18679           
=====================================
  Hits       15605   15605           
  Misses      2755    2755           
  Partials     319     319           
Files Changed Coverage Δ
exporters/otlp/internal/config.go 100.0% <ø> (ø)
exporters/otlp/internal/retry/retry.go 98.3% <ø> (ø)
...orters/otlp/otlpmetric/internal/oconf/envconfig.go 92.0% <ø> (ø)
...xporters/otlp/otlpmetric/internal/oconf/options.go 79.8% <ø> (ø)
exporters/otlp/otlptrace/exporter.go 66.6% <100.0%> (ø)

@MrAlias MrAlias marked this pull request as ready for review August 7, 2023 19:21
@MrAlias MrAlias marked this pull request as draft August 7, 2023 19:59
@MrAlias MrAlias marked this pull request as ready for review August 7, 2023 21:01
@MrAlias MrAlias merged commit 25a6f15 into open-telemetry:main Aug 8, 2023
21 checks passed
@MrAlias MrAlias deleted the dep-otlp-internal branch August 8, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:exporter:otlp Related to the OTLP exporter package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants