Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some makefile fixes #442

Merged
merged 2 commits into from
Jan 24, 2020
Merged

Some makefile fixes #442

merged 2 commits into from
Jan 24, 2020

Commits on Jan 24, 2020

  1. Generate and build before linting 

    Generated files may require some formatting that happens during
linting. Also missing generated files may result in linter failures.

Building can shake out any syntax/semantic errors and report them in a
much nicer way than the linter does. Which is exactly the reason the
build was running before linters before the Makefile simplification.
    @krnowak
    krnowak committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    66b28a7 View commit details
    Browse the repository at this point in the history

  2. Make stringer tool a dep of generate target, not lint 

    Lint target does not use the stringer utility - it is being used by go
generate.
    @krnowak
    krnowak committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    c0c6009 View commit details
    Browse the repository at this point in the history