Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade all use of semconv to v1.21.0 #4408

Merged
merged 8 commits into from
Aug 7, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Aug 4, 2023

Fix #4364

@MrAlias MrAlias added the pkg:semconv Related to a semconv package label Aug 4, 2023
@MrAlias MrAlias added this to the v1.17.0/v0.40.0 milestone Aug 4, 2023
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #4408 (6764e52) into main (196c1f0) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4408     +/-   ##
=======================================
- Coverage   83.5%   83.5%   -0.1%     
=======================================
  Files        229     229             
  Lines      18645   18647      +2     
=======================================
  Hits       15578   15578             
- Misses      2749    2751      +2     
  Partials     318     318             
Files Changed Coverage Δ
bridge/opentracing/internal/mock.go 67.0% <ø> (ø)
exporters/jaeger/jaeger.go 91.1% <ø> (ø)
exporters/otlp/otlpmetric/internal/otest/client.go 97.1% <ø> (ø)
...otlpmetric/otlpmetricgrpc/internal/otest/client.go 97.1% <ø> (ø)
...otlpmetric/otlpmetrichttp/internal/otest/client.go 97.1% <ø> (ø)
exporters/zipkin/model.go 94.7% <ø> (ø)
sdk/resource/builtin.go 90.3% <ø> (ø)
sdk/resource/container.go 92.3% <ø> (ø)
sdk/resource/env.go 94.0% <ø> (ø)
sdk/resource/host_id.go 97.4% <ø> (ø)
... and 3 more

... and 1 file with indirect coverage changes

Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as I do not find my comment as a blocker.

PS. I have forgotten to "add" my comment 🤦 Adding now...

@MrAlias MrAlias merged commit 9452b93 into open-telemetry:main Aug 7, 2023
21 checks passed
@MrAlias MrAlias deleted the upgrade-semconv-v1.21.0 branch August 7, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:semconv Related to a semconv package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump semconv to the latest version
3 participants