Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple otlp/otlpmetric/otlpmetricgrpc and otlp/otlpmetric/otlpmetrichttp from otlp/internal and otlp/otlpmetric/internal using gotmp #4403

Closed
wants to merge 13 commits into from

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Aug 2, 2023

Currently the otlp exporters share internal packages across package boundaries. This is something we want to stop doing: #3846. This PR addresses the cross-module internal package use for the otel/exporters/otlp/otlpmetric/otlpmetricgrpc otel/exporters/otlp/otlpmetric/otlpmetrichttp packages.

Additionally, it deprecates the otlpmetric/internal packages.

This PR is quite large. The plan is to break it apart and use this as the "road map" of where those subsequent PRs are going.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #4403 (b6d3457) into main (d1f33f1) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4403   +/-   ##
=====================================
  Coverage   83.4%   83.4%           
=====================================
  Files        229     229           
  Lines      18645   18645           
=====================================
  Hits       15551   15551           
  Misses      2775    2775           
  Partials     319     319           
Files Changed Coverage Δ
exporters/otlp/otlpmetric/internal/exporter.go 67.2% <ø> (ø)
...xporters/otlp/otlpmetric/internal/oconf/options.go 79.8% <ø> (ø)
exporters/otlp/otlpmetric/internal/otest/client.go 97.1% <ø> (ø)
...orters/otlp/otlpmetric/internal/otest/collector.go 6.9% <ø> (ø)

... and 2 files with indirect coverage changes

@MrAlias MrAlias closed this Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant