-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not block Temporality/Aggregation on OTLP metric export #4395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
pkg:SDK
Related to an SDK package
area:metrics
Part of OpenTelemetry Metrics
labels
Jul 31, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4395 +/- ##
=======================================
+ Coverage 83.4% 83.5% +0.1%
=======================================
Files 184 184
Lines 14380 14448 +68
=======================================
+ Hits 11997 12071 +74
+ Misses 2155 2147 -8
- Partials 228 230 +2
|
MrAlias
requested review from
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
July 31, 2023 17:11
If merged, supersedes #4001 |
dashpole
approved these changes
Jul 31, 2023
CharlieTLe
reviewed
Aug 1, 2023
pellared
reviewed
Aug 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
pellared
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #3925
Closes #4001
Currently for both the HTTP and gRPC OTLP metric exporters when
Export
is called all calls toAggregation
andTemporality
are blocked. This means the whole SDK processing pipeline, which calls these methods, becomes blocked. This is especially bad whenExport
hangs indefinitely due to an inaccessible target.Instead of having a universal
client
lock for a sharedExporter
from theotlpmetric/internal
package, have each exporter package implement a non-blockingExporter
directly. This removes the dependency on shared internal packages from an external module1.This does not completely remove the dependency on shared internal packages from an external module. That is left for a separate PR.
Footnotes
https://github.com/open-telemetry/opentelemetry-go/issues/3846 ↩