Use PeriodicReader timeout for ForceFlush #4377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prioritize the user passed context deadline if it has one.
Closed
2 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4377 +/- ##
=======================================
- Coverage 83.4% 83.4% -0.1%
=======================================
Files 184 184
Lines 14371 14380 +9
=======================================
+ Hits 11988 11995 +7
- Misses 2155 2157 +2
Partials 228 228
|
MrAlias
requested review from
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
dashpole
approved these changes
Jul 27, 2023
pellared
approved these changes
Jul 28, 2023
dmathieu
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prioritize the user passed context deadline if it has one.
From #3666 (comment)