Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the "go.opentelemetry.io/otel/sdk/export/metric" package name #432

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jan 15, 2020

Rename the package from "export" to "metric". Note that all the existing imports of this package (in this project) use an explicit package name of export and, therefore, no import declaration changes are included.

Rename the MetricKind to Kind to not stutter in the type usage. Note this does not include a method name change for the Descriptor method MetricKind.

@rghetia
Copy link
Contributor

rghetia commented Jan 16, 2020

@MrAlias can you please rebase?

Rename the package from "export" to "metric". Note that all the existing
imports of this package use an explicit name of `export` and, therefore,
no import declaration changes are included.

Rename the `MetricKind` to `Kind` to not stutter in the type usage. Note
this does not include a method name change for the `Descriptor` method
`MetricKind`.
@rghetia rghetia merged commit dcd0a10 into open-telemetry:master Jan 16, 2020
@MrAlias MrAlias deleted the rename-metric-export-pkg branch January 16, 2020 18:45
@MrAlias MrAlias mentioned this pull request Feb 11, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants