Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proof-of-concept: OTel Resource scope and namespace API #427

Closed
wants to merge 22 commits into from
Closed

Proof-of-concept: OTel Resource scope and namespace API #427

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
f279218
Add new files from old branch
jmacd Jan 7, 2020
96f5e8f
SDK tests pass
jmacd Jan 8, 2020
a305554
Global tests pass; trace provider removed
jmacd Jan 8, 2020
ec35065
Remove trace.Provider
jmacd Jan 8, 2020
7e9a323
API and SDK tests pass
jmacd Jan 8, 2020
919b664
Exporter/API/SDK tests pass
jmacd Jan 9, 2020
dae443c
All tests except bridge
jmacd Jan 9, 2020
258010b
Checkpoint bridge & Tidy
jmacd Jan 9, 2020
4c81dbd
Replace WithNamespace by SDK suffix
jmacd Jan 9, 2020
f95e60b
Make scope.Current() return the global by default
jmacd Jan 9, 2020
e8cd8d0
Remove dead comments
jmacd Jan 9, 2020
3d9ffed
Rename
jmacd Jan 9, 2020
2edabc3
Restore the sugar API
jmacd Jan 9, 2020
25c7dd6
example/basic/main.go
jmacd Jan 10, 2020
5863667
Most examples build (some tests to go)
jmacd Jan 10, 2020
08e1c1c
Lint etc.
jmacd Jan 10, 2020
e338471
Remove most uses of scope.Empty
jmacd Jan 11, 2020
8bf3be3
Comments & alignment fix
jmacd Jan 11, 2020
3909dc9
Cleanups: remove ContextWithScope and scope.Empty
jmacd Jan 11, 2020
f09713e
Comments
jmacd Jan 11, 2020
6e6e833
WithTracer -> WithTracerSDK
jmacd Jan 11, 2020
8bed2e1
Precommit
jmacd Jan 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Comments
  • Loading branch information
@jmacd
jmacd committed Jan 11, 2020
commit f09713e6f81347f06425d5c25f65f961670f9c4e
4 changes: 2 additions & 2 deletions api/context/scope/current.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ func (s Scope) InContext(ctx context.Context) context.Context {
}

// Current returns the Scope associated with a Context as set by
// ContextWithScope. If no Scope is located in the context, the
// global scope will be used.
// Scope.InContext(). If no Scope is located in the context, the
// global scope will be returned.
func Current(ctx context.Context) Scope {
impl := internal.ScopeImpl(ctx)
if impl == nil {
Expand Down