Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk/metric: Reader factories return structs #4244

Merged
merged 3 commits into from
Jun 22, 2023

Conversation

pellared
Copy link
Member

Fixes #4243

@pellared pellared added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #4244 (e3467a6) into main (ca2aa83) will increase coverage by 0.0%.
The diff coverage is 95.4%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4244   +/-   ##
=====================================
  Coverage   83.5%   83.5%           
=====================================
  Files        181     181           
  Lines      14161   14161           
=====================================
+ Hits       11825   11827    +2     
+ Misses      2109    2107    -2     
  Partials     227     227           
Impacted Files Coverage Δ
sdk/metric/periodic_reader.go 91.8% <92.3%> (ø)
sdk/metric/manual_reader.go 85.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

CHANGELOG.md Show resolved Hide resolved
@pellared pellared requested a review from dmathieu June 21, 2023 08:29
@pellared pellared merged commit 6b262b4 into open-telemetry:main Jun 22, 2023
@pellared pellared deleted the ret-reader-structs branch June 22, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

sdk/metric: NewManualReader and NewPeriodicReader should return structs
4 participants