Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exponential Histogram Datatypes #4165

Merged
merged 6 commits into from
Jun 14, 2023

Conversation

MadVikingGod
Copy link
Contributor

@MadVikingGod MadVikingGod commented Jun 1, 2023

This patch introduces the Exponential Histogram datatype in the Metrics SDK. This is the serializable format that exporters will use.

This patch does not do the follow, and will this functionality be added in follow on patches:

  • Prepare the OTLP exporter to handle this type.
  • Create an Aggregator that will export this

EDIT: OTel Spec for reference: https://github.com/open-telemetry/opentelemetry-specification/blob/v1.21.0/specification/metrics/data-model.md#exponentialhistogram

CHANGELOG.md Outdated Show resolved Hide resolved
sdk/metric/metricdata/data.go Outdated Show resolved Hide resolved
sdk/metric/metricdata/data.go Outdated Show resolved Hide resolved
sdk/metric/metricdata/data.go Outdated Show resolved Hide resolved
sdk/metric/metricdata/data.go Show resolved Hide resolved
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

sdk/metric/metricdata/data.go Outdated Show resolved Hide resolved
sdk/metric/metricdata/data.go Show resolved Hide resolved
sdk/metric/metricdata/data.go Show resolved Hide resolved
sdk/metric/metricdata/data.go Outdated Show resolved Hide resolved
sdk/metric/metricdata/data.go Outdated Show resolved Hide resolved
sdk/metric/metricdata/data.go Outdated Show resolved Hide resolved
sdk/metric/metricdata/data.go Outdated Show resolved Hide resolved
sdk/metric/metricdata/data.go Outdated Show resolved Hide resolved
sdk/metric/metricdata/data.go Outdated Show resolved Hide resolved
sdk/metric/metricdata/data.go Show resolved Hide resolved
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #4165 (7a36242) into main (844b107) will increase coverage by 0.1%.
The diff coverage is 99.2%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4165     +/-   ##
=======================================
+ Coverage   83.3%   83.4%   +0.1%     
=======================================
  Files        181     181             
  Lines      13986   14116    +130     
=======================================
+ Hits       11657   11786    +129     
- Misses      2102    2103      +1     
  Partials     227     227             
Impacted Files Coverage Δ
sdk/metric/metricdata/data.go 50.0% <0.0%> (-7.2%) ⬇️
sdk/metric/metricdata/metricdatatest/assertion.go 88.9% <100.0%> (+1.6%) ⬆️
...dk/metric/metricdata/metricdatatest/comparisons.go 90.5% <100.0%> (+2.3%) ⬆️

@MadVikingGod MadVikingGod mentioned this pull request Jun 5, 2023
3 tasks
@MadVikingGod MadVikingGod self-assigned this Jun 8, 2023
@MrAlias MrAlias merged commit b757c70 into open-telemetry:main Jun 14, 2023
@MadVikingGod MadVikingGod deleted the mvg/exp-hist-data branch June 15, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

4 participants