Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine CONTRIBUTING.md: make test is included in make precommit #416

Merged
merged 2 commits into from
Jan 6, 2020
Merged

Refine CONTRIBUTING.md: make test is included in make precommit #416

merged 2 commits into from
Jan 6, 2020

Conversation

clsung
Copy link
Contributor

@clsung clsung commented Jan 3, 2020

Since e6d7256 , make precommit also runs make test

@lizthegrey lizthegrey merged commit 7236396 into open-telemetry:master Jan 6, 2020
@clsung clsung deleted the refine_contrib branch January 7, 2020 12:47
@MrAlias MrAlias mentioned this pull request Jan 7, 2020
Closed
6 tasks
@MrAlias MrAlias mentioned this pull request Feb 11, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias approved these changes

@jmacd jmacd jmacd approved these changes

@lizthegrey lizthegrey lizthegrey approved these changes

@iredelmeier iredelmeier Awaiting requested review from iredelmeier

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

@rghetia rghetia Awaiting requested review from rghetia

@tedsuo tedsuo Awaiting requested review from tedsuo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clsung @lizthegrey @jmacd @MrAlias