Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Message in Event to Name #389

Merged
merged 1 commit into from
Dec 18, 2019
Merged

Rename Message in Event to Name #389

merged 1 commit into from
Dec 18, 2019

Conversation

clsung
Copy link
Contributor

@clsung clsung commented Dec 18, 2019 •
edited by rghetia
Loading

fixes #387

@jmacd
Copy link
Contributor

jmacd commented Dec 18, 2019

It's pretty awesome to file an issue around midnight and have a PR waiting in the morning :-)

In any case, for the record, I came to discover this discrepancy after reviewing open-telemetry/opentelemetry-specification#397

@rghetia rghetia merged commit 09ae537 into open-telemetry:master Dec 18, 2019
@rghetia rghetia mentioned this pull request Dec 18, 2019
Closed
@clsung clsung deleted the event_msg_to_name branch December 27, 2019 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rghetia rghetia rghetia approved these changes

@jmacd jmacd jmacd approved these changes

@iredelmeier iredelmeier Awaiting requested review from iredelmeier

@lizthegrey lizthegrey Awaiting requested review from lizthegrey

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

@tedsuo tedsuo Awaiting requested review from tedsuo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Events have a _Name_ field, not a _Message_
3 participants
@clsung @jmacd @rghetia