-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate metric/unit
and use a string
for units in the metric API/SDK
#3776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
pkg:API
Related to an API package
pkg:SDK
Related to an SDK package
area:metrics
Part of OpenTelemetry Metrics
labels
Feb 24, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3776 +/- ##
=======================================
- Coverage 81.7% 81.7% -0.1%
=======================================
Files 167 167
Lines 12462 12450 -12
=======================================
- Hits 10184 10172 -12
Misses 2063 2063
Partials 215 215
|
Deprecate the units package. This package will not be included in the metric GA.
MrAlias
changed the title
Replace Unit from metric/unit with string
Deprecate Feb 24, 2023
metric/unit
and use a string
for units in the metric API/SDK
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
February 24, 2023 19:09
Aneurysm9
approved these changes
Feb 24, 2023
MadVikingGod
approved these changes
Feb 25, 2023
unicod3
reviewed
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:metrics
Part of OpenTelemetry Metrics
pkg:API
Related to an API package
pkg:SDK
Related to an SDK package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3775
The OTel specification states a unit needs to be a string that is not validated by the API or SDK, and the API design of the
unit
package is brittle and will not evolve well. This deprecates theunit
package so it will be removed in the next release, and replace all use of theUnit
type with astring
throughout the metric signal.