readme: fix quick start example #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jazzdan
requested review from
iredelmeier,
jmacd,
lizthegrey,
paivagustavo,
rghetia,
sjkaris and
tedsuo
as code owners
lizthegrey
approved these changes
Dec 6, 2019
jazzdan
force-pushed
the
dmiller/fix-readme-quick-start
branch
from
004ab80
to
e0452ee
Compare
rghetia
approved these changes
Dec 6, 2019
|
Thank you for this first contribution! |
hstan
referenced
this pull request
in hstan/opentelemetry-go
Oct 15, 2020
…rovider (#374) * Update gopkg.in/macaron.v1/otelmacaron inst to use TracerProvider * Add changes to changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the API changed. I diff'd this against the basic example in the example directory and came up with something that works.