change trace.WithAttributes to append values instead of replacing #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paivagustavo
requested review from
jmacd,
pjanotti,
rghetia,
sjkaris and
tedsuo
as code owners
jmacd
approved these changes
Nov 14, 2019
rghetia
approved these changes
Nov 14, 2019
| @@ -206,7 +206,7 @@ func WithStartTime(t time.Time) SpanOption { | |||
| // data about the span. | |||
| func WithAttributes(attrs ...core.KeyValue) SpanOption { | |||
There was a problem hiding this comment.
can you please update the doc to indicate that multiple call to WithAttribute will appends the attributes? or something along the line.
lizthegrey
approved these changes
Nov 14, 2019
lizthegrey
approved these changes
Nov 14, 2019
hstan
referenced
this pull request
in hstan/opentelemetry-go
Oct 15, 2020
…alTLS Test (#315) * Add static ECSDA cert files, cert generator script, and update auth_test * Add new line and comment to cert generation script * Remove extra new line from comment * Add test for generated certs and fix file names * Change key generation to ecdsa p256 * Run certificate generator script to retry CI tests * Remove static certificate files and bash script * Update comment to retry tests * Update comment to retry tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #309.