Clear NoopTracer implementation and improve Tracer argument names #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paivagustavo
requested review from
jmacd,
pjanotti,
rghetia,
sjkaris and
tedsuo
as code owners
|
I'll suggest we also removed those in internal/trace/mock_tracer.go and sdk/trace/tracer.go |
jmacd
approved these changes
Nov 14, 2019
lizthegrey
approved these changes
Nov 14, 2019
|
Should we also not remove from sdk/trace/tracer.go and internal/trace/mock_tracer.go? |
lizthegrey
approved these changes
Nov 14, 2019
|
Yeah, for some reason I thought clsung sent a PR for the other structs, guess I was wake dreaming 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #307, closes #303
Remove methods that are not well defined on the trace specs for and improve arguments names/docs from the
Tracerinterface.Since both are small changes I preferred doing a single PR.