example/basic: make basic example work #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
clsung
commented
Nov 2, 2019
clsung
commented
- use stdout as exportor (otherwise no output when you run it)
- use stdout as exportor (otherwise no output when you run it)
clsung
requested review from
bogdandrutu,
jmacd,
pjanotti,
rghetia,
sjkaris and
tedsuo
as code owners
rghetia
reviewed
Nov 4, 2019
example/basic/main.go
Outdated
| func main() { | ||
| initTracer() | ||
| tracer := global.TraceProvider().GetTracer("ex.com/basic") | ||
| meter := global.MeterProvider().GetMeter("ex.com/basic") // TODO: should share resources ^^^? |
There was a problem hiding this comment.
please add a note that Meter doesn't work yet.
There was a problem hiding this comment.
Just rephrase TODO, thanks.
There was a problem hiding this comment.
FYI there is a Meter stdout exporter in #265, which also adds to this example.
It's fine to remove the note about flush.
jmacd
approved these changes
Nov 4, 2019
|
For me, the TODO about resources is a spec-level "nice-to-have". It should be relatively easy to add resources to the meter and tracer in a coordinated way, but we haven't specified a way to do that. I believe the right approach would be to combine the two interfaces and support a common method for adding resources to a Tracer/Meter combo. |
rghetia
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.