Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sdk/export/metric module #2720

Merged
merged 7 commits into from
Mar 29, 2022
Merged

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Mar 23, 2022

This was deprecated two minor releases ago.

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #2720 (28a678f) into main (8747a29) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2720     +/-   ##
=======================================
- Coverage   76.7%   76.7%   -0.1%     
=======================================
  Files        181     181             
  Lines      12175   12175             
=======================================
- Hits        9349    9347      -2     
- Misses      2601    2603      +2     
  Partials     225     225             
Impacted Files Coverage Δ
sdk/trace/batch_span_processor.go 81.1% <0.0%> (-1.0%) ⬇️

Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@MrAlias
Copy link
Contributor Author

MrAlias commented Mar 25, 2022

Holding off merging until #2727 is merged and https://github.com/open-telemetry/opentelemetry-go/milestone/18 is complete.

@MrAlias MrAlias added this to the Release v1.7.0 milestone Mar 28, 2022
@MrAlias MrAlias merged commit bbcdc75 into open-telemetry:main Mar 29, 2022
@MrAlias MrAlias deleted the rm-sdk-export branch March 29, 2022 14:31
@MrAlias MrAlias modified the milestones: Release v1.6.2, Release v1.7.0 Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants