-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace master with specific jaeger tag version in otel-collector #2622
Replace master with specific jaeger tag version in otel-collector #2622
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2622 +/- ##
=======================================
- Coverage 76.0% 75.9% -0.1%
=======================================
Files 173 173
Lines 12293 12293
=======================================
- Hits 9344 9342 -2
- Misses 2702 2704 +2
Partials 247 247
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URLs are invalid
This seems a bit brittle, and we'll have to make sure we don't go too much behind on the version used. |
@hanyuancheung can you address these unresolved issues so we can move to merging this? |
Sure. How about updating the jaeger operator version to v1.31.0, and pointing to the jaeger's documentation via an annotation in makefile? |
@dmathieu please take another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK (but I have not tested it 😬 ).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested it either. But it looks good to me.
Fix #2617