Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace master with specific jaeger tag version in otel-collector #2622

Merged
merged 7 commits into from
Mar 1, 2022

Conversation

hanyuancheung
Copy link
Member

Fix #2617

  • Cannot use master as the "version", instead of using pined versions.
  • Replace master with specific jaeger tag version in otel-collector example.

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #2622 (d9e533b) into main (a1fff3c) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2622     +/-   ##
=======================================
- Coverage   76.0%   75.9%   -0.1%     
=======================================
  Files        173     173             
  Lines      12293   12293             
=======================================
- Hits        9344    9342      -2     
- Misses      2702    2704      +2     
  Partials     247     247             
Impacted Files Coverage Δ
sdk/trace/batch_span_processor.go 81.1% <0.0%> (-1.0%) ⬇️

@pellared pellared added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 17, 2022
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URLs are invalid

example/otel-collector/Makefile Outdated Show resolved Hide resolved
@pellared pellared dismissed their stale review February 17, 2022 14:06

it should work now

@dmathieu
Copy link
Member

This seems a bit brittle, and we'll have to make sure we don't go too much behind on the version used.
How about rewording the example so that it points directly to jaeger's documentation instead of duplicating it here?

@MrAlias MrAlias added this to the Release v1.5.0 milestone Feb 23, 2022
@MrAlias
Copy link
Contributor

MrAlias commented Feb 25, 2022

@hanyuancheung
Copy link
Member Author

@hanyuancheung can you address these unresolved issues so we can move to merging this?

Sure. How about updating the jaeger operator version to v1.31.0, and pointing to the jaeger's documentation via an annotation in makefile?

@MrAlias
Copy link
Contributor

MrAlias commented Feb 25, 2022

@dmathieu please take another look.

Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK (but I have not tested it 😬 ).

Copy link
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested it either. But it looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Otel-collector example refers to non-existing raw files
6 participants