Separate example modules #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iredelmeier
requested review from
bogdandrutu,
pjanotti,
rghetia,
sjkaris and
tedsuo
as code owners
|
Please remove the binary file 'basic'. |
iredelmeier
force-pushed
the
separate-example-modules
branch
from
acb2036
to
aae0d3a
Compare
pjanotti
reviewed
Jun 26, 2019
jmacd
approved these changes
Jun 27, 2019
|
@iredelmeier can you please rebase and resolve the conflicts so I can merge this? |
iredelmeier
force-pushed
the
separate-example-modules
branch
from
aae0d3a
to
bc9550f
Compare
pjanotti
approved these changes
Jul 15, 2019
iredelmeier
force-pushed
the
separate-example-modules
branch
from
bc9550f
to
e982130
Compare
iredelmeier
force-pushed
the
separate-example-modules
branch
from
e982130
to
26cda3f
Compare
This prevents core code from including dependencies required only for examples, reducing the number of dependencies that core code needs to rely on.
iredelmeier
force-pushed
the
separate-example-modules
branch
from
26cda3f
to
834fbe3
Compare
hstan
referenced
this pull request
in hstan/opentelemetry-go
Oct 15, 2020
* Copy mongo driver * Add an updated copy of otel-go mock tracer * Integrate mock tracer * Update tests * Update copyright * Move to plugins dir * Move mongo plugin to go.mongodb.org dir * Upgrade to v0.5.0 * Run make Includes fixes needed to past testing. * Update attribution Based on [this](open-telemetry/community#305 (comment)) comment, updating attribution to be to The OpenTelemetry Authors. * package.go -> doc.go * Update package name * Update package docs * Suggested fix for docs * Apply feedback * Remove unneeded go.mod replaces * Update testing service name Co-authored-by: Krzesimir Nowak <krzesimir@kinvolk.io> Co-authored-by: Tyler Yahn <codingalias@gmail.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduced the core module's number of dependencies (based on
go.sum) from 257 down to 22. As we add more examples, the impact will likely only get more significant. This gets us a significant way towards addressing the Dependencies portion of #19 (can't link directly to that header - sorry!).Some notes:
replacein the examplego.modfiles is the best way to handle things. I believe it's appropriate since the example modules should be versioned in lockstep with the main one, but I might be wrong :)