-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change gc
runtime name to go
#2560
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
January 28, 2022 08:59
dmathieu
commented
Jan 28, 2022
Codecov Report
@@ Coverage Diff @@
## main #2560 +/- ##
=======================================
- Coverage 76.2% 76.2% -0.1%
=======================================
Files 173 173
Lines 12249 12253 +4
=======================================
+ Hits 9341 9342 +1
- Misses 2661 2664 +3
Partials 247 247
|
MrAlias
approved these changes
Feb 4, 2022
I have rebased this PR against the main branch. |
pellared
approved these changes
Feb 14, 2022
Per the specification: open-telemetry/opentelemetry-specification#2262
We still need a third review on this given @pellared and I work for the same company. |
jmacd
approved these changes
Feb 23, 2022
6 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the specification: open-telemetry/opentelemetry-specification#2262
Closes #2510