Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change gc runtime name to go #2560

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Change gc runtime name to go #2560

merged 2 commits into from
Feb 23, 2022

Conversation

dmathieu
Copy link
Member

@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #2560 (4af12c7) into main (0a6e4d8) will decrease coverage by 0.0%.
The diff coverage is 80.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2560     +/-   ##
=======================================
- Coverage   76.2%   76.2%   -0.1%     
=======================================
  Files        173     173             
  Lines      12249   12253      +4     
=======================================
+ Hits        9341    9342      +1     
- Misses      2661    2664      +3     
  Partials     247     247             
Impacted Files Coverage Δ
sdk/resource/process.go 98.4% <80.0%> (-1.6%) ⬇️
sdk/trace/batch_span_processor.go 81.1% <0.0%> (-1.0%) ⬇️

@dmathieu
Copy link
Member Author

I have rebased this PR against the main branch.

@MrAlias
Copy link
Contributor

MrAlias commented Feb 23, 2022

We still need a third review on this given @pellared and I work for the same company.

@MrAlias MrAlias merged commit a15269a into open-telemetry:main Feb 23, 2022
@dmathieu dmathieu deleted the go-runtime-name branch February 24, 2022 08:34
@MrAlias MrAlias added this to the Release v1.5.0 milestone Feb 24, 2022
@MrAlias MrAlias mentioned this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the process.runtime.name resource to go for the default Go compiler
6 participants