Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix specify explicit buckets in example #2493

Conversation

hanyuancheung
Copy link
Member

@hanyuancheung hanyuancheung commented Jan 3, 2022

Fix: #2419

  • Multiple buckets are expected in Prometheus example, some of which are perhaps empty.
  • BTW, Change the original example to show how to specify explicit buckets.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #2493 (c83d041) into main (4b815ff) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2493   +/-   ##
=====================================
  Coverage   76.3%   76.3%           
=====================================
  Files        173     173           
  Lines      12022   12022           
=====================================
+ Hits        9175    9182    +7     
+ Misses      2602    2597    -5     
+ Partials     245     243    -2     
Impacted Files Coverage Δ
sdk/metric/sdk.go 81.5% <0.0%> (+1.4%) ⬆️
sdk/metric/refcount_mapped.go 100.0% <0.0%> (+20.0%) ⬆️

@MrAlias MrAlias added the pkg:example Related to an example label Jan 4, 2022
@MrAlias MrAlias merged commit 1c1e846 into open-telemetry:main Jan 4, 2022
@MrAlias MrAlias mentioned this pull request Feb 10, 2022
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:example Related to an example
Projects
None yet
Development

Successfully merging this pull request may close these issues.

example/prometheus: histogram has only +Inf buckets
6 participants