Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables collectorConnectionDiesThenReconnects because it is flaky #2373

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

MadVikingGod
Copy link
Contributor

This disables a test that has become more and more problematic. It was originally reported in #1527, and has gotten progressively worse.

I would recommend we reenable if there is a PR that fixes it, or when #2329 is accepted.

@Aneurysm9 Aneurysm9 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 11, 2021
@MrAlias MrAlias added the bug Something isn't working label Nov 11, 2021
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add skips in these locations?

func TestNew_collectorConnectionDiesThenReconnectsWhenInRestMode(t *testing.T) {

func TestNewExporter_collectorConnectionDiesThenReconnectsWhenInRestMode(t *testing.T) {

and

func TestNewExporter_collectorConnectionDiesThenReconnects(t *testing.T) {

@MadVikingGod
Copy link
Contributor Author

I most defantly can add it there. I was just starting with the one that was consistently failing. To see if that made the other fail as well.

@MrAlias
Copy link
Contributor

MrAlias commented Nov 11, 2021

I most defantly can add it there. I was just starting with the one that was consistently failing. To see if that made the other fail as well.

From what I've seen they all fail at an equal rate.

Copy link
Contributor

@evantorrie evantorrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I've fought these tests more than I care to...

@MrAlias
Copy link
Contributor

MrAlias commented Nov 11, 2021

/easycla

@MrAlias MrAlias mentioned this pull request Nov 11, 2021
@MrAlias
Copy link
Contributor

MrAlias commented Nov 11, 2021

I was able to resolve the EasyCLA issues with #2374 in #2378 by getting rid of all the commits made though GitHub.

  • Rebase to main git rebase upstream/main
  • Force a collapse of all changes in the branch to a single commit
    git reset $(git merge-base main $(git branch --show-current))
    git add .
    git commit
    
  • Finally, force pushing

@MadVikingGod
Copy link
Contributor Author

phew, it passed the easy CLA

@MrAlias
Copy link
Contributor

MrAlias commented Nov 12, 2021

phew, it passed the easy CLA

I don't want to mess things up by hitting the "Update branch" button. Can you rebase this to the latest on main?

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #2373 (cdc6e99) into main (a65d50a) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2373   +/-   ##
=====================================
  Coverage   73.8%   73.8%           
=====================================
  Files        175     175           
  Lines      12436   12436           
=====================================
+ Hits        9185    9189    +4     
+ Misses      3015    3012    -3     
+ Partials     236     235    -1     
Impacted Files Coverage Δ
...s/otlp/otlptrace/internal/connection/connection.go 14.6% <0.0%> (-1.6%) ⬇️
sdk/metric/sdk.go 81.6% <0.0%> (+1.4%) ⬆️
sdk/metric/refcount_mapped.go 100.0% <0.0%> (+20.0%) ⬆️

@MrAlias MrAlias merged commit 45d2592 into open-telemetry:main Nov 12, 2021
@evantorrie
Copy link
Contributor

Yay!

@MadVikingGod MadVikingGod deleted the disable_flaky_test branch February 21, 2023 19:56
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants