-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disables collectorConnectionDiesThenReconnects because it is flaky #2373
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also add skips in these locations?
func TestNew_collectorConnectionDiesThenReconnectsWhenInRestMode(t *testing.T) { |
func TestNewExporter_collectorConnectionDiesThenReconnectsWhenInRestMode(t *testing.T) { |
and
func TestNewExporter_collectorConnectionDiesThenReconnects(t *testing.T) { |
I most defantly can add it there. I was just starting with the one that was consistently failing. To see if that made the other fail as well. |
From what I've seen they all fail at an equal rate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I've fought these tests more than I care to...
/easycla |
I was able to resolve the EasyCLA issues with #2374 in #2378 by getting rid of all the commits made though GitHub.
|
acec02a
to
30b55cb
Compare
phew, it passed the easy CLA |
I don't want to mess things up by hitting the "Update branch" button. Can you rebase this to the latest on main? |
30b55cb
to
cdc6e99
Compare
Codecov Report
@@ Coverage Diff @@
## main #2373 +/- ##
=====================================
Coverage 73.8% 73.8%
=====================================
Files 175 175
Lines 12436 12436
=====================================
+ Hits 9185 9189 +4
+ Misses 3015 3012 -3
+ Partials 236 235 -1
|
Yay! |
This disables a test that has become more and more problematic. It was originally reported in #1527, and has gotten progressively worse.
I would recommend we reenable if there is a PR that fixes it, or when #2329 is accepted.