-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adds vanity import check. #2255
chore: adds vanity import check. #2255
Conversation
5444762
to
42c8f06
Compare
Have you tried to add https://github.com/jcchavezs/porto/ to https://github.com/golangci/golangci-lint? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@pellared that was actually an idea but first I wanted to see this in action here. |
This is failing now on purpose. I wanted it to fail to test the setup. |
Do we need to update changelog? |
Codecov Report
@@ Coverage Diff @@
## main #2255 +/- ##
=====================================
Coverage 72.4% 72.5%
=====================================
Files 168 168
Lines 11872 11872
=====================================
+ Hits 8606 8609 +3
+ Misses 3031 3029 -2
+ Partials 235 234 -1
|
This PR adds check on CI to verify vanity imports are rightfully added.