-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: create new linked span from current context #2115
Merged
MrAlias
merged 7 commits into
open-telemetry:main
from
bhautikpip:add_link_from_context_api
Jul 22, 2021
Merged
API: create new linked span from current context #2115
MrAlias
merged 7 commits into
open-telemetry:main
from
bhautikpip:add_link_from_context_api
Jul 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhautikpip
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
July 21, 2021 19:41
Aneurysm9
approved these changes
Jul 21, 2021
jmacd
approved these changes
Jul 21, 2021
Codecov Report
@@ Coverage Diff @@
## main #2115 +/- ##
=====================================
Coverage 72.9% 72.9%
=====================================
Files 167 167
Lines 8237 8240 +3
=====================================
+ Hits 6009 6014 +5
+ Misses 1994 1992 -2
Partials 234 234
|
MrAlias
approved these changes
Jul 22, 2021
Looks like this needs a changelog entry before we can merge it. |
Thanks @MrAlias I will update the |
…y-go into add_link_from_context_api
…kpip/opentelemetry-go into add_link_from_context_api
6 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added API
LinkFromContext
to returnLink
which encapsulates SpanContext from provided context and also encapsulates attributesResolve #2068
Resolve #2067