Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: create new linked span from current context #2115

Merged
merged 7 commits into from
Jul 22, 2021

Conversation

bhautikpip
Copy link
Contributor

@bhautikpip bhautikpip commented Jul 21, 2021

Added API LinkFromContext to return Link which encapsulates SpanContext from provided context and also encapsulates attributes

Resolve #2068
Resolve #2067

@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #2115 (e78a735) into main (db81d4a) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2115   +/-   ##
=====================================
  Coverage   72.9%   72.9%           
=====================================
  Files        167     167           
  Lines       8237    8240    +3     
=====================================
+ Hits        6009    6014    +5     
+ Misses      1994    1992    -2     
  Partials     234     234           
Impacted Files Coverage Δ
trace/trace.go 98.3% <100.0%> (+<0.1%) ⬆️
exporters/jaeger/jaeger.go 94.2% <0.0%> (+1.1%) ⬆️

trace/trace.go Outdated Show resolved Hide resolved
@MrAlias
Copy link
Contributor

MrAlias commented Jul 22, 2021

Looks like this needs a changelog entry before we can merge it.

@bhautikpip
Copy link
Contributor Author

Thanks @MrAlias I will update the CHANGELOG.

@MrAlias MrAlias merged commit abe2243 into open-telemetry:main Jul 22, 2021
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants