Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP metrics exporter for OTLP #2022

Merged

Conversation

hanyuancheung
Copy link
Member

@hanyuancheung hanyuancheung commented Jun 19, 2021

Resolved: #2014 this is part of the #1827 todo list:

  • add gRPC otlp trace exporter
  • add gRPC otlp metrics exporter
  • add HTTP otlp trace exporter
  • add HTTP otlp metrics exporter
  • refactor out the duplicated code (transform, connection, otlpconfig)
  • update examples and remove old otlp gRPC/HTTP exporter
  • update docs

@codecov
Copy link

codecov bot commented Jun 19, 2021

Codecov Report

Merging #2022 (4bee63f) into main (d6e8f60) will increase coverage by 0.2%.
The diff coverage is 88.2%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2022     +/-   ##
=======================================
+ Coverage   72.4%   72.7%   +0.2%     
=======================================
  Files        161     164      +3     
  Lines       7943    8079    +136     
=======================================
+ Hits        5756    5876    +120     
- Misses      1961    1974     +13     
- Partials     226     229      +3     
Impacted Files Coverage Δ
...ers/otlp/otlpmetric/internal/otlpconfig/options.go 64.9% <0.0%> (-7.7%) ⬇️
...porters/otlp/otlpmetric/otlpmetrichttp/exporter.go 0.0% <0.0%> (ø)
exporters/otlp/otlpmetric/otlpmetrichttp/client.go 93.2% <93.2%> (ø)
...xporters/otlp/otlpmetric/otlpmetrichttp/options.go 100.0% <100.0%> (ø)

@hanyuancheung hanyuancheung force-pushed the add_HTTP_metrics_exporter_for_OTLP branch from b4e0e15 to a5689ab Compare June 19, 2021 16:20
@hanyuancheung hanyuancheung force-pushed the add_HTTP_metrics_exporter_for_OTLP branch from f194bfc to 62e36e6 Compare June 19, 2021 17:53
@hanyuancheung
Copy link
Member Author

Hi, all checks have passed, could anyone convenient help to review this PR? Thx.

CHANGELOG.md Outdated Show resolved Hide resolved
exporters/otlp/otlpmetric/otlpmetrichttp/doc.go Outdated Show resolved Hide resolved
exporters/otlp/otlpmetric/otlpmetrichttp/doc.go Outdated Show resolved Hide resolved
hanyuancheung and others added 3 commits June 22, 2021 00:29
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Copy link
Member

@paivagustavo paivagustavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this @zhyChesterCheung. Some small comments but overall looks good!

.github/dependabot.yml Outdated Show resolved Hide resolved
exporters/otlp/otlpmetric/otlpmetrichttp/options.go Outdated Show resolved Hide resolved
@hanyuancheung
Copy link
Member Author

The problems mentioned above all have been fixed ~ @MrAlias @paivagustavo

@MrAlias
Copy link
Contributor

MrAlias commented Jun 22, 2021

@zhyChesterCheung can you merge in main and resolve the existing conflicts? This PR still needs another approval from an approver before it can be merged, but having it ready to merge will speed that up once it happens.

@hanyuancheung
Copy link
Member Author

hanyuancheung commented Jun 22, 2021

@zhyChesterCheung can you merge in main and resolve the existing conflicts? This PR still needs another approval from an approver before it can be merged, but having it ready to merge will speed that up once it happens.

All conflicts have been resolved, great to see the checks all passed and this PR is ready to merge. Could you merge it please? @MrAlias @paivagustavo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HTTP support for OTLP metrics exporter
4 participants