Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inputPath validation to semconv-gen/generator.go #1986

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Add inputPath validation to semconv-gen/generator.go #1986

merged 1 commit into from
Jun 9, 2021

Conversation

eddyleelin
Copy link
Contributor

@eddyleelin eddyleelin commented Jun 9, 2021 •
edited by MrAlias
Loading

Fixes #1984

@Aneurysm9 Aneurysm9 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 9, 2021
@Aneurysm9 Aneurysm9 merged commit 7ffe284 into open-telemetry:main Jun 9, 2021
@eddyleelin eddyleelin deleted the add-semconvgen-inputpath-validation branch July 27, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias approved these changes

@dashpole dashpole dashpole approved these changes

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@evantorrie evantorrie Awaiting requested review from evantorrie

@jmacd jmacd Awaiting requested review from jmacd

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Internal semconv-gen/generator.go script does not enforce validatation of inputPath
4 participants
@eddyleelin @Aneurysm9 @dashpole @MrAlias