Generate semantic conventions according to specification version #1933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
force-pushed
the
feature/tigran/semconv-gen-by-ver
branch
3 times, most recently
from
0bbf8b3
to
9485966
Compare
tigrannajaryan
changed the title
tigrannajaryan
commented
May 20, 2021
|
@Aneurysm9 does this work the way you expected it should in your comment here #1890 (comment) ? |
Aneurysm9
reviewed
May 20, 2021
|
@Aneurysm9 PTAL. |
Aneurysm9
reviewed
May 21, 2021
tigrannajaryan
changed the title
Closed
tigrannajaryan
added
the
Skip Changelog
tigrannajaryan
force-pushed
the
feature/tigran/semconv-gen-by-ver
branch
from
5b67ba8
to
d9c3763
Compare
…d version This modifies the generation tool to generate the content from the latest tagged version of the specification (previously it was just using whatever the spec repo's working directory contained). The generated files will be now placed in a sub-directory with a name matching the tagged version number. The generated package will be placed under the "semconv" directory. Note: we will use the new logic generate the semconv/v1.3.0 package in a separate future PR.
tigrannajaryan
force-pushed
the
feature/tigran/semconv-gen-by-ver
branch
from
d9c3763
to
b3c4c5a
Compare
tigrannajaryan
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1933 +/- ##
=======================================
- Coverage 76.3% 76.3% -0.1%
=======================================
Files 157 157
Lines 8358 8358
=======================================
- Hits 6380 6378 -2
- Misses 1723 1725 +2
Partials 255 255
|
tigrannajaryan
requested review from
dashpole,
evantorrie,
jmacd,
MadVikingGod,
paivagustavo and
XSAM
as code owners
|
@Aneurysm9 @MrAlias this is ready for review. |
Aneurysm9
approved these changes
May 27, 2021
dashpole
approved these changes
May 28, 2021
|
Can we merge this or need to wait for more reviews? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the generation tool to generate the content from the latest tagged
version of the specification (previously it was just using whatever the spec repo's
working directory contained).
The generated files will be now placed in a sub-directory with a name matching the
tagged version number. The generated package will be placed under the "semconv" directory.