Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unembed SpanContext #1877

Merged
merged 2 commits into from
May 4, 2021
Merged

Conversation

IrisTuntun
Copy link
Contributor

Unembed SpanContext in Link so that Link can be correctly Marshaled. Should resolve #1820 .

rebase branch
@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #1877 (449f7b7) into main (b7d02db) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #1877   +/-   ##
=====================================
  Coverage   78.7%   78.7%           
=====================================
  Files        137     137           
  Lines       7339    7339           
=====================================
+ Hits        5780    5782    +2     
+ Misses      1317    1316    -1     
+ Partials     242     241    -1     
Impacted Files Coverage Δ
trace/trace.go 86.7% <ø> (ø)
exporters/otlp/internal/transform/span.go 98.1% <100.0%> (ø)
exporters/trace/jaeger/jaeger.go 92.8% <100.0%> (ø)
sdk/trace/batch_span_processor.go 87.1% <0.0%> (+1.5%) ⬆️

@Aneurysm9 Aneurysm9 merged commit 42a8450 into open-telemetry:main May 4, 2021
@Aneurysm9 Aneurysm9 mentioned this pull request Jun 17, 2021
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trace.Link omits its Attributes field when marshalled to JSON
4 participants