Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Default Value for Jaeger Exporter Endpoint #1824

Merged

Conversation

s-nadendla
Copy link
Contributor

Updated Jaeger Exporter endpoint default value to match Open Telemetry specification:

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #1824 (4c6b1fd) into main (0032bd6) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #1824     +/-   ##
=======================================
- Coverage   78.4%   78.3%   -0.1%     
=======================================
  Files        135     135             
  Lines       7252    7246      -6     
=======================================
- Hits        5688    5680      -8     
- Misses      1317    1318      +1     
- Partials     247     248      +1     
Impacted Files Coverage Δ
exporters/trace/jaeger/env.go 100.0% <ø> (ø)
exporters/trace/jaeger/uploader.go 36.9% <100.0%> (ø)
sdk/trace/batch_span_processor.go 82.4% <0.0%> (-1.6%) ⬇️

CHANGELOG.md Outdated Show resolved Hide resolved
exporters/trace/jaeger/uploader.go Outdated Show resolved Hide resolved
exporters/trace/jaeger/uploader.go Outdated Show resolved Hide resolved
exporters/trace/jaeger/uploader.go Outdated Show resolved Hide resolved
exporters/trace/jaeger/uploader.go Outdated Show resolved Hide resolved
exporters/trace/jaeger/uploader.go Outdated Show resolved Hide resolved
exporters/trace/jaeger/uploader.go Outdated Show resolved Hide resolved
exporters/trace/jaeger/uploader.go Outdated Show resolved Hide resolved
exporters/trace/jaeger/uploader.go Outdated Show resolved Hide resolved
exporters/trace/jaeger/uploader.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
example/jaeger/main.go Outdated Show resolved Hide resolved
@Aneurysm9 Aneurysm9 merged commit e43d9c0 into open-telemetry:main Apr 21, 2021
@MrAlias MrAlias mentioned this pull request Apr 23, 2021
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants