-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Default Value for Jaeger Exporter Endpoint #1824
Merged
Aneurysm9
merged 10 commits into
open-telemetry:main
from
open-o11y:UpdateDefaultJaegerCollectorEndpoint
Apr 21, 2021
Merged
Update Default Value for Jaeger Exporter Endpoint #1824
Aneurysm9
merged 10 commits into
open-telemetry:main
from
open-o11y:UpdateDefaultJaegerCollectorEndpoint
Apr 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-nadendla
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MrAlias,
paivagustavo and
XSAM
as code owners
April 19, 2021 18:19
Codecov Report
@@ Coverage Diff @@
## main #1824 +/- ##
=======================================
- Coverage 78.4% 78.3% -0.1%
=======================================
Files 135 135
Lines 7252 7246 -6
=======================================
- Hits 5688 5680 -8
- Misses 1317 1318 +1
- Partials 247 248 +1
|
MrAlias
reviewed
Apr 19, 2021
MrAlias
approved these changes
Apr 21, 2021
MrAlias
reviewed
Apr 21, 2021
Aneurysm9
approved these changes
Apr 21, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Jaeger Exporter endpoint default value to match Open Telemetry specification: