Fix OTLP testing flake: signal connection from mock collector #1816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mock collector listener now signals when it receives a connection instead of waiting an arbitrary time an hoping the event happens.
MrAlias
added
bug
MrAlias
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
paivagustavo and
XSAM
as code owners
Aneurysm9
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a TCP Listener implementation to the mock collector that signals when it receives a connection. Use this signaling in testing to wait for re connections to deterministically happen instead of waiting an arbitrary time and hoping it happens.
Validated this fix here.
Resolve #1527