Fix flaky OTLP exporter reconnect test #1814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests that check the OTLP exporter will reconnect wait for the reconnect loop to complete, in theory. However, they do not yield the active goroutine scheduling. The reconnect loop is in its own goroutine meaning it is unlikely for that loop to be re-entered, especially on slow systems. This updates the tests call runtime.Gosched when waiting for the reconnect loop and yield the scheduling to other goroutines.
MrAlias
added
bug
MrAlias
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
paivagustavo and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1814 +/- ##
=======================================
- Coverage 78.6% 78.6% -0.1%
=======================================
Files 134 134
Lines 7158 7158
=======================================
- Hits 5632 5630 -2
- Misses 1276 1278 +2
Partials 250 250
|
|
This looks like it has not completely resolved this issue: https://github.com/open-telemetry/opentelemetry-go/pull/1814/checks?check_run_id=2346462483 I think it is a step forward and should be merged still, but will remove the linked issue as being resolved. |
Aneurysm9
approved these changes
Apr 14, 2021
paivagustavo
approved these changes
Apr 14, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests that check the OTLP exporter will reconnect wait for the reconnect loop to complete, in theory. However, they do not yield the active goroutine scheduling. The reconnect loop is in its own goroutine meaning it is unlikely for that loop to be re-entered, especially on slow systems. This updates the tests call runtime.Gosched when waiting for the reconnect loop and yield the scheduling to other goroutines.
This does not clean up the duplicate testing (
TestNewExporter_collectorConnectionDiesThenReconnectsWhenInRestModeseems to be a paired down version ofTestNewExporter_collectorConnectionDiesThenReconnects), which I'm planning to address in a follow up PR. Because of this, the reuse of the "wait" function is just duplicated instead of abstracted into its own declaration.Related to #1527