Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for env var configuration to otlp/gRPC #1811

Merged
merged 13 commits into from
Apr 16, 2021
Merged

add support for env var configuration to otlp/gRPC #1811

merged 13 commits into from
Apr 16, 2021

Conversation

paivagustavo
Copy link
Member

@paivagustavo paivagustavo commented Apr 14, 2021

  • Added env var config to the otlp/gRPC driver.
  • I did a small refactor to the otlp/HTTP options to make it reusable in the otlp/gRPC driver.
  • Since I needed to refactor both drivers to accept different connection and configuration when sending data to traces and metrics, I've also added some more context to some errors.

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #1811 (c6501ca) into main (d616df6) will decrease coverage by 0.1%.
The diff coverage is 81.7%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #1811     +/-   ##
=======================================
- Coverage   78.6%   78.4%   -0.2%     
=======================================
  Files        134     135      +1     
  Lines       7158    7236     +78     
=======================================
+ Hits        5630    5679     +49     
- Misses      1278    1307     +29     
  Partials     250     250             
Impacted Files Coverage Δ
exporters/otlp/otlpgrpc/options.go 44.4% <44.4%> (-43.1%) ⬇️
exporters/otlp/otlphttp/options.go 56.0% <54.1%> (-36.5%) ⬇️
exporters/otlp/otlpgrpc/connection.go 92.5% <78.5%> (+3.7%) ⬆️
exporters/otlp/otlpgrpc/driver.go 88.7% <88.0%> (-1.5%) ⬇️
exporters/otlp/internal/otlpconfig/options.go 90.8% <90.8%> (ø)
exporters/otlp/internal/otlpconfig/envconfig.go 92.5% <94.4%> (ø)
exporters/otlp/otlphttp/driver.go 94.6% <100.0%> (+<0.1%) ⬆️

@paivagustavo paivagustavo added release:1.0.0-rc.1 pkg:exporter:otlp Related to the OTLP exporter package labels Apr 14, 2021
@paivagustavo
Copy link
Member Author

I've just noticed that this does implement the timeout option that should exist in the gRPC exporter as well. I'll tackle down this in another PR.

exporters/otlp/internal/otlpconfig/options.go Outdated Show resolved Hide resolved
exporters/otlp/otlpgrpc/options.go Outdated Show resolved Hide resolved
exporters/otlp/otlpgrpc/options.go Outdated Show resolved Hide resolved
exporters/otlp/otlpgrpc/options.go Outdated Show resolved Hide resolved
exporters/otlp/otlpgrpc/options.go Outdated Show resolved Hide resolved
exporters/otlp/otlpgrpc/options.go Outdated Show resolved Hide resolved
exporters/otlp/otlphttp/options.go Outdated Show resolved Hide resolved
@MrAlias
Copy link
Contributor

MrAlias commented Apr 16, 2021

I've just noticed that this does implement the timeout option that should exist in the gRPC exporter as well. I'll tackle down this in another PR.

Does this mean that #1085 should not be closed by this PR @paivagustavo?

@paivagustavo
Copy link
Member Author

I've just noticed that this does implement the timeout option that should exist in the gRPC exporter as well. I'll tackle down this in another PR.

Does this mean that #1085 should not be closed by this PR @paivagustavo?

Yes, I'll update this PR description to not close the issue.

@MrAlias MrAlias merged commit a2cecb6 into open-telemetry:main Apr 16, 2021
@paivagustavo paivagustavo deleted the add_support_env_var_otlp_grpc branch April 16, 2021 21:55
@MrAlias MrAlias mentioned this pull request Apr 23, 2021
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:exporter:otlp Related to the OTLP exporter package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants