Add ExportSpans benchmark to Jaeger exporter #1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
release:1.0.0-rc.1
pkg:exporter:jaeger
MrAlias
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
paivagustavo and
XSAM
as code owners
MrAlias
added
pkg:testing
Aneurysm9
approved these changes
Apr 13, 2021
Codecov Report
@@ Coverage Diff @@
## main #1805 +/- ##
=======================================
- Coverage 78.4% 78.4% -0.1%
=======================================
Files 135 135
Lines 7236 7236
=======================================
- Hits 5679 5677 -2
- Misses 1307 1309 +2
Partials 250 250
|
MadVikingGod
approved these changes
Apr 16, 2021
XSAM
approved these changes
Apr 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a step to address #1799 this adds benchmarks to the Jaeger exporter to ensure we have a metric of performance to measure against.
Part of #1803