Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typo for default service name in Jaeger Exporter #1797

Merged
merged 7 commits into from
Apr 12, 2021
Merged

Fixed typo for default service name in Jaeger Exporter #1797

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c5cec7f
Fix typo in jaeger exporter
humivo Apr 9, 2021
76641f5
Update changelog
humivo Apr 9, 2021
c1e61cc
Merge branch 'main' into 1783-JaegerServiceNameTypo
humivo Apr 9, 2021
765fc79
Add PR number to changelog
humivo Apr 12, 2021
50c94b4
Add PR number to changelog
humivo Apr 12, 2021
b3dccc4
Move entry in changelog to Fixed
humivo Apr 12, 2021
a0582a0
Merge branch 'main' into 1783-JaegerServiceNameTypo
MrAlias Apr 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
- The Jaeger exporter now correctly records Span event's names using the `"event"` key for a tag.
Additionally, this tag is overridden, as specified in the OTel specification, if the event contains an attribute with that key. (#1768)
- Zipkin Exporter: Ensure mapping between OTel and Zipkin span data complies with the specification. (#1688)
- Fixed typo for default service name in Jaeger Exporter. (#1797)

### Changed

Expand Down
2 changes: 1 addition & 1 deletion exporters/trace/jaeger/jaeger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@ func process(res *resource.Resource, defaultServiceName string) *gen.Process {
// If no service.name is contained in a Span's Resource,
// that field MUST be populated from the default Resource.
if serviceName.Value.AsString() == "" {
serviceName = semconv.ServiceVersionKey.String(defaultServiceName)
serviceName = semconv.ServiceNameKey.String(defaultServiceName)
}
process.ServiceName = serviceName.Value.AsString()

Expand Down