Zipkin Exporter: Use default resouce's serviceName as default serivce name #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lastchiliarch
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MrAlias,
paivagustavo and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1786 +/- ##
=====================================
Coverage 78.6% 78.6%
=====================================
Files 134 134
Lines 7156 7159 +3
=====================================
+ Hits 5630 5633 +3
Misses 1276 1276
Partials 250 250
|
lastchiliarch
force-pushed
the
issue1777
branch
3 times, most recently
from
5a76626
to
dbafffd
Compare
MrAlias
reviewed
Apr 8, 2021
… name (open-telemetry#1777) Signed-off-by: lastchiliarch <lastchiliarch@163.com>
lastchiliarch
force-pushed
the
issue1777
branch
from
dbafffd
to
b39a573
Compare
Aneurysm9
approved these changes
Apr 12, 2021
MrAlias
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zipkin Exporter: Use default resouce's serviceName as default serivce name, see #1777 .
Signed-off-by: lastchiliarch lastchiliarch@163.com