Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ExportSpans for Jaeger Exporter honor deadline #1773

Merged
merged 11 commits into from
Apr 5, 2021

Conversation

humivo
Copy link
Member

@humivo humivo commented Apr 2, 2021

Made the ExportSpans method for Jaegar Exporter use AddWait instead of Add in order to honor the context deadline. Should resolve Issue #1730

@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #1773 (8d355ba) into main (0786fe3) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #1773     +/-   ##
=======================================
- Coverage   78.7%   78.7%   -0.1%     
=======================================
  Files        134     134             
  Lines       7136    7140      +4     
=======================================
+ Hits        5618    5620      +2     
- Misses      1272    1274      +2     
  Partials     246     246             
Impacted Files Coverage Δ
exporters/trace/jaeger/jaeger.go 93.7% <100.0%> (+0.1%) ⬆️
exporters/otlp/otlpgrpc/connection.go 88.7% <0.0%> (-1.9%) ⬇️
sdk/trace/batch_span_processor.go 80.9% <0.0%> (ø)

exporters/trace/jaeger/jaeger.go Outdated Show resolved Hide resolved
exporters/trace/jaeger/jaeger.go Outdated Show resolved Hide resolved
@humivo humivo requested a review from MrAlias April 5, 2021 19:01
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than we need to check the error string

exporters/trace/jaeger/jaeger_test.go Outdated Show resolved Hide resolved
exporters/trace/jaeger/jaeger_test.go Outdated Show resolved Hide resolved
@humivo humivo requested a review from MrAlias April 5, 2021 19:57
@MrAlias MrAlias merged commit 5bbfc22 into open-telemetry:main Apr 5, 2021
@MrAlias MrAlias mentioned this pull request Apr 23, 2021
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jaeger exporter: ExportSpans should honor context deadline
6 participants