-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record links/events attribute drops independently #1771
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1771 +/- ##
=======================================
- Coverage 78.7% 78.7% -0.1%
=======================================
Files 134 134
Lines 7140 7144 +4
=======================================
Hits 5626 5626
- Misses 1270 1272 +2
- Partials 244 246 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nit: We should be able to remove the assignment sd.DroppedAttributeCount = int(s.droppedAttributeCount)
, on the span.Snapshot()
method, since the span.droppedAttributeCount
is only populated by the attributesMap
now.
ad418b6
to
828c1db
Compare
Added
Event
andLink
struct types from thego.opentelemetry.io/otel
package now include aDroppedAttributeCount
field to record the number of attributes that were not recorded due to configured limits being reached.Changed
DroppedAttributeCount
field of theSpan
in thego.opentelemetry.io/otel
package now only represents the number of attributes dropped for the span itself. It no longer is a conglomerate of itself, events, and link attributes that have been dropped.Resolves #1766