Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record links/events attribute drops independently #1771

Merged
merged 7 commits into from
Apr 6, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Apr 1, 2021

Added

  • The Event and Link struct types from the go.opentelemetry.io/otel package now include a DroppedAttributeCount field to record the number of attributes that were not recorded due to configured limits being reached.
  • The Jaeger exporter now reports dropped attributes for a Span event in the exported log.

Changed

  • The DroppedAttributeCount field of the Span in the go.opentelemetry.io/otel package now only represents the number of attributes dropped for the span itself. It no longer is a conglomerate of itself, events, and link attributes that have been dropped.

Resolves #1766

@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #1771 (5f366c1) into main (5bbfc22) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #1771     +/-   ##
=======================================
- Coverage   78.7%   78.7%   -0.1%     
=======================================
  Files        134     134             
  Lines       7140    7144      +4     
=======================================
  Hits        5626    5626             
- Misses      1270    1272      +2     
- Partials     244     246      +2     
Impacted Files Coverage Δ
trace/trace.go 86.7% <ø> (ø)
exporters/trace/jaeger/jaeger.go 93.8% <100.0%> (+0.1%) ⬆️
sdk/trace/span.go 94.0% <100.0%> (ø)
sdk/metric/refcount_mapped.go 77.7% <0.0%> (-22.3%) ⬇️
sdk/metric/sdk.go 80.2% <0.0%> (-1.2%) ⬇️

Copy link
Member

@paivagustavo paivagustavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nit: We should be able to remove the assignment sd.DroppedAttributeCount = int(s.droppedAttributeCount), on the span.Snapshot() method, since the span.droppedAttributeCount is only populated by the attributesMap now.

@MrAlias MrAlias merged commit e9aaa04 into open-telemetry:main Apr 6, 2021
@MrAlias MrAlias deleted the attr-drop-counts branch April 6, 2021 14:51
@MrAlias MrAlias mentioned this pull request Apr 23, 2021
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Record dropped attribute count as Jaeger log
5 participants