Fix Jaeger span status reporting and unify tag keys #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move all tag key strings to be consts defined in a unified location. Fix the status code and message tag keys to conform with the specification. Do not set the span status message if it is not set to conform with the specification.
MrAlias
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
paivagustavo and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1761 +/- ##
=======================================
- Coverage 78.6% 78.6% -0.1%
=======================================
Files 133 133
Lines 7073 7072 -1
=======================================
- Hits 5561 5560 -1
Misses 1267 1267
Partials 245 245
|
Aneurysm9
approved these changes
Apr 1, 2021
XSAM
approved these changes
Apr 1, 2021
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
This was referenced Apr 1, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all tag key strings to be consts defined in a unified location.
Fix the status code and message tag keys to conform with the specification.
Do not set the span status message if it is not set to conform with the specification.
Part of #1376 and #1605