Add ExportTimeout option to batch span processor
#1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matej-g
force-pushed
the
export-timeout-batch-span-processor
branch
from
5677471
to
c9572b7
Compare
Codecov Report
@@ Coverage Diff @@
## main #1755 +/- ##
=======================================
+ Coverage 78.6% 78.7% +0.1%
=======================================
Files 134 134
Lines 7129 7136 +7
=======================================
+ Hits 5605 5618 +13
+ Misses 1275 1272 -3
+ Partials 249 246 -3
|
matej-g
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MrAlias,
paivagustavo and
XSAM
as code owners
MrAlias
approved these changes
Mar 30, 2021
Aneurysm9
approved these changes
Mar 30, 2021
XSAM
approved these changes
Mar 31, 2021
MrAlias
requested changes
Mar 31, 2021
MrAlias
approved these changes
Apr 5, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
ExportTimeoutoption to batch span processor, in order to make it comply with the specification (relevant part). Cancellation of the export should be achieved by passing a context with deadline to the exporter's method.Resolves #1613