-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Jaeger environment variables #1752
Update Jaeger environment variables #1752
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1752 +/- ##
=======================================
- Coverage 78.7% 78.6% -0.2%
=======================================
Files 134 134
Lines 7180 7156 -24
=======================================
- Hits 5656 5628 -28
- Misses 1274 1278 +4
Partials 250 250
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we support OTEL_EXPORTER_JAEGER_AGENT_HOST
and OTEL_EXPORTER_JAEGER_AGENT_PORT
, which listed in #1639 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
@s-nadendla this looks ready to merge, can you resolve the conflicts and merge the main branch in? |
Updated Jaeger environment variables to match Open Telemetry specification:
Removed
envServiceName
andenvTags
since the Jaeger exporter already gets attributes from a Resource that has its own system for determining environment values; overriding these values here is unnecessary. Removed this logic and the corresponding testsAddresses: #1639