Remove hasRemoteParent field from SDK span #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the newly added SpanContext.IsRemote method instead.
MrAlias
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1728 +/- ##
=======================================
- Coverage 78.0% 77.9% -0.1%
=======================================
Files 131 131
Lines 6954 6953 -1
=======================================
- Hits 5425 5422 -3
- Misses 1279 1281 +2
Partials 250 250
|
Aneurysm9
approved these changes
Mar 24, 2021
MadVikingGod
approved these changes
Mar 25, 2021
jmacd
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the newly added SpanContext.IsRemote method instead.