Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove makeSamplingDecision func #1711

Merged
merged 3 commits into from
Mar 20, 2021
Merged

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Mar 18, 2021

The makeSamplingDecision function is a wrapper around the provider sampler calling ShouldSample with a duplicate configuration struct. That duplication and need for translation as well as the addition function call is unnecessary, this function is called in only one place.

Resolves #1706

The makeSamplingDecision function is a wrapper around the provider
sampler calling ShouldSample with a duplicate configuration struct. That
duplication and need for translation as well as the addition function
call is unnecessary, this function is called in only one place.

Resolves open-telemetry#1706
@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 18, 2021
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #1711 (a65209d) into main (e24702d) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #1711     +/-   ##
=======================================
- Coverage   77.9%   77.8%   -0.1%     
=======================================
  Files        131     131             
  Lines       6997    6986     -11     
=======================================
- Hits        5451    5440     -11     
  Misses      1296    1296             
  Partials     250     250             
Impacted Files Coverage Δ
sdk/trace/span.go 90.4% <100.0%> (-0.5%) ⬇️

@MrAlias MrAlias merged commit 5d559b4 into open-telemetry:main Mar 20, 2021
@MrAlias MrAlias deleted the fix-1706 branch March 20, 2021 16:19
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove makeSamplingDecision and duplicate samplingData struct.
4 participants