SpanStatus description set only when status code is set to Error #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrveera
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
…ode is set to error
mrveera
force-pushed
the
span-status-description
branch
from
8e30da1
to
ae32ac7
Compare
MrAlias
approved these changes
Mar 5, 2021
MrAlias
reviewed
Mar 5, 2021
Codecov Report
@@ Coverage Diff @@
## main #1662 +/- ##
=====================================
Coverage 77.3% 77.3%
=====================================
Files 128 128
Lines 6693 6694 +1
=====================================
+ Hits 5178 5179 +1
Misses 1268 1268
Partials 247 247
|
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
MrAlias
approved these changes
Mar 5, 2021
Aneurysm9
approved these changes
Mar 5, 2021
XSAM
approved these changes
Mar 8, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1658