Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid overriding configuration of tracer provider #1633

Merged
merged 4 commits into from
Mar 8, 2021
Merged

Avoid overriding configuration of tracer provider #1633

merged 4 commits into from
Mar 8, 2021

Commits on Mar 8, 2021

  1. sdk/trace: add missing options to tracer provider 

    This change adds `WithDefaultSampler` and `WithSpanLimits` to the tracer
provider and removed `WithConfig` from it.

Before this change, `WithConfig` is the only way to set sampler or
limits of a span. However, it is prone to misuse, since `WithConfig` can
override tracing configurations that are configured by `WithResource` or
`WithIDGenerator`.  Thus to fix this, it adds new functional options -
`WithDefaultSampler` and `WithSpanLimits` and removes `WithConfig`.

Resolves open-telemetry#1631.
    @ijsong
    ijsong committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    549393e View commit details
    Browse the repository at this point in the history

  2. Update sdk/trace/provider.go 

    Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
    @ijsong @MrAlias
    ijsong and MrAlias committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    a2deff6 View commit details
    Browse the repository at this point in the history

  3. Update sdk/trace/provider.go 

    Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
    @ijsong @MrAlias
    ijsong and MrAlias committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    0e2f7a9 View commit details
    Browse the repository at this point in the history

  4. rebase and remove WithConfig

    @ijsong
    ijsong committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    4117ec1 View commit details
    Browse the repository at this point in the history