Remove vendor exclude from license-check #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey and
XSAM
as code owners
Aneurysm9
approved these changes
Feb 18, 2021
punya
reviewed
Feb 18, 2021
There was a problem hiding this comment.
I ended up using a different name third_party in #1551 because Go doesn't want you to use vendor for anything other than the official meaning of the term. I think we could actually remove the vendor clause in our license-check because we don't check anything into the official vendor location that's managed by go mod vendor.
MrAlias
changed the title
punya
approved these changes
Feb 18, 2021
XSAM
approved these changes
Feb 19, 2021
Aneurysm9
approved these changes
Feb 19, 2021
ldelossa
pushed a commit
to ldelossa/opentelemetry-go
that referenced
this pull request
Mar 5, 2021
* Update license-check to ignore all vendor dirs * Remove vendor path exclude from license-check find
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project does not contain any vendor directories.