Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds semantic conventions for exceptions #1492

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Adds semantic conventions for exceptions #1492

merged 1 commit into from
Apr 1, 2021

Commits on Apr 1, 2021

  1. Adds semantic conventions for exceptions

    Adds support for the opentelemetry exceptions semantic conventions. In
    short, this has RecordError produce an exception event with exception
    attributes instead of using the error event and error attributes.
    
    While golang does not have exceptions, the spec itself does not
    differentiate between errors and exceptions for recording purposes.
    RecordError was kept as the method name, both for backwards
    compatibility and to reduce confusion (the method signature takes in a
    golang error object). The spec appears to allow this, as it suggests the
    method is optional and signature may reflect whatever is most appropriate
    for the language implementing it.
    
    It may seem non-intuitive to log an exception event from a method called
    RecordError, but it's beneficial to have consistent behavior across all
    opentelemetry SDKs. Downstream projects like the opentelemetry-collector
    can build off of the published API and not special case behaviors from
    individual languages.
    mothershipper committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    c9249f6 View commit details
    Browse the repository at this point in the history