add NewExportPipeline and InstallNewPipeline for otlp #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: binjip978 <binjip978@gmail.com>
binjip978
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
|
|
Codecov Report
@@ Coverage Diff @@
## main #1373 +/- ##
=====================================
Coverage 78.8% 78.8%
=====================================
Files 134 134
Lines 7157 7180 +23
=====================================
+ Hits 5641 5660 +19
- Misses 1270 1271 +1
- Partials 246 249 +3
|
|
fixes #1347 Hello, i tried to make it consistent API with rest of NewExportPipeline and InstallNewPipeline, but it's hard, will be nice to hear some feedback. |
dashpole
reviewed
Nov 30, 2020
MrAlias
reviewed
Dec 1, 2020
added 3 commits
December 14, 2020 08:39
Signed-off-by: binjip978 <binjip978@gmail.com>
Aneurysm9
approved these changes
Jan 3, 2021
dashpole
approved these changes
Jan 7, 2021
Aneurysm9
suggested changes
Jan 12, 2021
CHANGELOG.md
Outdated
| @@ -52,6 +52,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
|
|
|||
| ### Added | |||
|
|
|||
| - The OTLP exporter now has two new convenience functions, `NewExportPipeline` and `InstallNewPipeline`, setup and install the exporter in tracing and metrics pipelines. (#1348) | |||
There was a problem hiding this comment.
This should be un the Unreleased section above, not under 0.14.0.
There was a problem hiding this comment.
updated and merged with current master
Signed-off-by: binjip978 <binjip978@gmail.com>
added 2 commits
January 16, 2021 09:04
Signed-off-by: binjip978 <binjip978@gmail.com>
Signed-off-by: binjip978 <binjip978@gmail.com>
|
Hi, @Aneurysm9, @MrAlias is this PR is still relevant? Im rebasing it time to time to make it work, but I not if it still needed. :) |
Aneurysm9
approved these changes
Apr 7, 2021
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
MrAlias
reviewed
Apr 8, 2021
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
MrAlias
approved these changes
Apr 8, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: binjip978 binjip978@gmail.com