Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s/HTTPUrlKey/HTTPURLKey/ in semconv #1338

Merged
merged 4 commits into from
Nov 16, 2020
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
- The prometheus exporter now exports non-monotonic counters (i.e. `UpDownCounter`s) as gauges. (#1210)
- Correct the `Span.End` method documentation in the `otel` API to state updates are not allowed on a span after it has ended. (#1310)
- Updated span collection limits for attribute, event and link counts to 1000 (#1318)
- Renamed `semconv.HTTPUrlKey` to `semconv.HTTPURLKey`. (#1338)

### Removed

Expand Down
2 changes: 1 addition & 1 deletion semconv/http.go
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ func HTTPClientAttributesFromHTTPRequest(request *http.Request) []label.KeyValue
attrs = append(attrs, HTTPMethodKey.String(http.MethodGet))
}

attrs = append(attrs, HTTPUrlKey.String(request.URL.String()))
attrs = append(attrs, HTTPURLKey.String(request.URL.String()))

return append(attrs, httpCommonAttributesFromHTTPRequest(request)...)
}
Expand Down
2 changes: 1 addition & 1 deletion semconv/trace.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ const (

// Full HTTP request URL in the form:
// scheme://host[:port]/path?query[#fragment].
HTTPUrlKey = label.Key("http.url")
HTTPURLKey = label.Key("http.url")

// The full request target as passed in a HTTP request line or
// equivalent, e.g. "/path/12314/?q=ddds#123".
Expand Down